Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors in rdp backend #1941

Closed
nedludd opened this issue Nov 30, 2019 · 3 comments
Closed

Build errors in rdp backend #1941

nedludd opened this issue Nov 30, 2019 · 3 comments

Comments

@nedludd
Copy link

@nedludd nedludd commented Nov 30, 2019

I'm getting this when I build against the latest freerdp-git package (in Arch)

./backend/rdp/peer.c: In function ‘rdp_peer_context_new’:
../backend/rdp/peer.c:256:2: error: ‘nsc_context_set_pixel_format’ is deprecated [-Werror=deprecated-declarations]
  256 |  nsc_context_set_pixel_format(context->nsc_context, PIXEL_FORMAT_BGRA32);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/winpr2/winpr/synch.h:29,
                 from /usr/include/winpr2/winpr/wlog.h:33,
                 from /usr/include/freerdp2/freerdp/codec/color.h:26,
                 from ../include/backend/rdp.h:3,
                 from ../backend/rdp/peer.c:10:
/usr/include/freerdp2/freerdp/codec/nsc.h:47:36: note: declared here
   47 |  FREERDP_API WINPR_DEPRECATED(BOOL nsc_context_set_pixel_format(NSC_CONTEXT* context,
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/winpr2/winpr/winpr.h:53:31: note: in definition of macro ‘WINPR_DEPRECATED’
   53 | #define WINPR_DEPRECATED(obj) obj __attribute__((deprecated))
      |                               ^~~

Got it to work by disabling freerdp, but not sure what that effect that has on Sway, which did build cleanly after this.

@colemickens

This comment has been minimized.

Copy link
Contributor

@colemickens colemickens commented Jan 9, 2020

Freerdp has marked that function deprecated since the latest stable release. There's an easy fix - I actually patch wlroots and friends and build against HEAD freerdp (since freerdp-stable doesn't actually work under Wayland). It's a very simple patch I apply after cloning, before building: https://github.com/colemickens/nixpkgs-wayland/blob/22ea9e08ce2ef6817b722fe80c757ab35ed227c5/pkgs/wlroots/default.nix#L22

@emersion

This comment has been minimized.

Copy link
Member

@emersion emersion commented Jan 10, 2020

Can you send this as a pull request, @colemickens?

@colemickens

This comment has been minimized.

Copy link
Contributor

@colemickens colemickens commented Jan 11, 2020

Since the backend was dropped, I won't send a PR and I think this can be closed.

(Is there a wayvnc equivalent for RDP underway, maybe?)

@emersion emersion closed this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.