Implement xwayland-keyboard-grab-unstable-v1

[Ongy]

This protocol allows things like dmenu_run to work properly (i.e. steal keybaord focus) while other windows (e.g. dunst) that don't require keyboard focus don't steal it.

https://github.com/wayland-project/wayland-protocols/blob/master/unstable/xwayland-keyboard-grab/xwayland-keyboard-grab-unstable-v1.xml

---

wlroots has migrated to gitlab.freedesktop.org. This issue has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/624

[emersion]

We found out this is unrelated to dmenu and we've chosen not to provide an implementation for it.

[ammen99]

I think it may be time to reconsider implementing this. My tests with GNOME on Wayland show that this protocol IS used when for ex. VirtualBox is running.

[subdiff]

Indeed VirtualBox is one of the interesting use cases for this extension. But it is also needed for certain Wayland native clients (for example KWin's nested sessions or qemu VMs). There is also the keyboard_shortcuts_inhibit_unstable_v1 protocol, which does apparently the same for arbitrary Wayland clients, but is not supported by XWayland. I'm not sure why there are two different protocols, one for XWayland alone.

You also have https://github.com/swaywm/wlr-protocols/blob/master/unstable/wlr-input-inhibitor-unstable-v1.xml

What's your plan on all these together?

[Ongy]

Do you have a source on this being used in VMs native?
Iirc this specifically says it should only be exposed to xwayland and other clients shouldn't get access to the protocol.

Thus getting them together isn't exactly anything to plan for. One is legacy support, the other a more generic method going forward

[Ongy]

I should get into the habit of reading a full comment again..
The shortcut-inhibit and input-inhibitor are both for native clients.
Shortcut inhibit+pointer constraints might be better for VMs than input-inhibitor

[emersion]

input-inhibitor is a privileged protocol for lockscreens. Indeed xwayland-keyboard-grab-unstable-v1 shouldn't be exposed to regular clients.