Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es): Use &dyn Comments to reduce binary size #7489

Merged
merged 3 commits into from
Jun 5, 2023
Merged

perf(es): Use &dyn Comments to reduce binary size #7489

merged 3 commits into from
Jun 5, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 5, 2023

@kdy1 kdy1 added this to the Planned milestone Jun 5, 2023
@kdy1 kdy1 self-assigned this Jun 5, 2023
@kdy1 kdy1 force-pushed the tr-generics branch 2 times, most recently from e7dfb25 to fa1339d Compare June 5, 2023 03:34
@kdy1 kdy1 changed the title perf(es/compat): Make compat transforms not overly generic perf(es): Use &dyn Comments to reduce binary size Jun 5, 2023
@kdy1 kdy1 marked this pull request as ready for review June 5, 2023 03:48
@kdy1 kdy1 enabled auto-merge (squash) June 5, 2023 03:48
kdy1
kdy1 commented Jun 5, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc

@kdy1 kdy1 disabled auto-merge June 5, 2023 03:50
@kdy1 kdy1 enabled auto-merge (squash) June 5, 2023 03:51
@kdy1 kdy1 mentioned this pull request Jun 5, 2023
Merged
@kdy1 kdy1 disabled auto-merge June 5, 2023 04:03
@kdy1 kdy1 merged commit 2c3ac68 into swc-project:main Jun 5, 2023
128 checks passed
@kdy1 kdy1 deleted the tr-generics branch June 5, 2023 04:04
kodiakhq bot pushed a commit to vercel/turbo that referenced this pull request Jun 5, 2023
@kdy1
refactor: Do not duplicate SWC transforms in the final binary (#5200)
e8259c6 
### Description

This PR modifies generic instantiation to use `&dyn Comments` instead of
`SwcComments`, to reduce binary size along with
swc-project/swc#7489.

### Testing Instructions

I'll post the binary size once
swc-project/swc#7489 is merged.

---

 - Previous binary size: `133.4MiB`
 - New binary size: `132.4MiB`


---


Closes WEB-1148
@kdy1 kdy1 mentioned this pull request Jun 5, 2023
Closed
mehulkar pushed a commit to vercel/turbo that referenced this pull request Jun 5, 2023
@kdy1 @mehulkar
refactor: Do not duplicate SWC transforms in the final binary (#5200)
9060b38 
### Description

This PR modifies generic instantiation to use `&dyn Comments` instead of
`SwcComments`, to reduce binary size along with
swc-project/swc#7489.

### Testing Instructions

I'll post the binary size once
swc-project/swc#7489 is merged.

---

 - Previous binary size: `133.4MiB`
 - New binary size: `132.4MiB`


---


Closes WEB-1148
@kdy1 kdy1 modified the milestones: Planned, v1.3.63 Jun 12, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.63
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kdy1