feat(es/codegen): ability to set indentation string via rust api #7494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 5, 2023
| @@ -33,6 +34,7 @@ impl<'a, W: Write> JsWriter<'a, W> { | |||
| ) -> Self { | |||
| JsWriter { | |||
| indent: Default::default(), | |||
| indent_str: " ", | |||
There was a problem hiding this comment.
Perhaps this should be set in the constructor like new_line?
There was a problem hiding this comment.
Ah, nevermind. Let's use set_indent_str instead for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the ability to set the indentation string of JsWriter via the Rust API. The motivation behind this change is to allow people to use other indentation in the emit output like tabs or two spaces via the Rust API.