Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es): Accept parse option for minify() #7543

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 19, 2023

Description:

We don't support them. but this is to make API more compatible with terser.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jun 19, 2023
@kdy1 kdy1 self-assigned this Jun 19, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc

@kdy1 kdy1 marked this pull request as ready for review June 19, 2023 04:35
@kdy1 kdy1 enabled auto-merge (squash) June 19, 2023 04:35
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge June 19, 2023 05:38
@kdy1 kdy1 enabled auto-merge (squash) June 19, 2023 05:50
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 1d84e95 into swc-project:main Jun 19, 2023
127 checks passed
@kdy1 kdy1 deleted the issue-7455 branch June 19, 2023 06:34
@kdy1 kdy1 modified the milestones: Planned, v1.3.66 Jun 20, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

unknown field parse, expected one of compress, ...
2 participants