Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Add usage to inlined ident eagerly #7597

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

Austaras
Copy link
Member

Description:
Closes #7591

BREAKING CHANGE:

Related issue (if exists):

self.mode.store(id.clone(), &*init);

let usage_count = usage.usage_count;
let mut inc_usage = || {
Copy link
Member Author

@Austaras Austaras Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly. But I can't think of a better way.

@kdy1 kdy1 requested a review from jridgewell June 29, 2023 12:16
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 added this to the Planned milestone Jun 29, 2023
@kdy1 kdy1 self-assigned this Jun 29, 2023
@kdy1 kdy1 enabled auto-merge (squash) July 4, 2023 04:20
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 4f866de into swc-project:main Jul 4, 2023
249 checks passed
@Austaras Austaras deleted the hoist branch July 4, 2023 12:23
@kdy1 kdy1 modified the milestones: Planned, v1.3.68 Jul 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minifying multiple references to variable pointing at hoisted function breaks
4 participants