fix(es/compat): Fix loose mode of the spread pass

[lsdyi]

Description:

Related issue:

• Closes spread syntax differs between swc loose mode and babel loose mode #7354

[CLAassistant]

All committers have signed the CLA.

[lsdyi]

@kdy1 Sorry to push code without tests. I'm new to this repo🥹, kind of confused where I can complete whole testing process. I noticed we can write input/index.js and inpuit/.swcrc which I think are input example, but I'm confused how I can generate output, which is output/index.js

[kdy1]

You can do UPDATE=1 cargo test

[kdy1]

Also, can you sign the CLA?

[kdy1]

CI is failing. You can update snapshots with UPDATE=1 cargo test

[lsdyi]

@kdy1 Thank you for the reminder :) I'm going to working on this pr today. Updating the Snapshots.

[lsdyi]

Hello @kdy1 , I update the testing file and snapshots. Could you please help me check the code?

[kdy1]

This clone seems redundant.

[lsdyi]

exprused without clonemethod will cause use of moved value error in next *expr location.

---

Error stack is as follows.

error[E0382]: use of moved value: `*expr`
   --> crates/swc_ecma_transforms_compat/src/es2015/spread.rs:286:34
    |
258 |                 arg_list.push(expr.as_arg());
    |                                    -------- `*expr` moved due to this method call
...
286 |                         buf.push(match *expr {
    |                                  ^^^^^^^^^^^ value used here after move
    |
    = note: move occurs because `*expr` has type `swc_ecma_ast::Expr`, which does not implement the `Copy` trait
help: you can `clone` the value and consume it, but this might not be your desired behavior
    |
258 |                 arg_list.push(expr.clone().as_arg());
    |                                    ++++++++

For more information about this error, try `rustc --explain E0382`.
error: could not compile `swc_ecma_transforms_compat` (lib) due to previous error

---

$ rustc --version
rustc 1.70.0-nightly (da7c50c08 2023-03-19)

[lsdyi]

Thanks for the CR yesterday @kdy1 , is there anything I can do with this PR?

[kdy1]

Please remove the redundant clone. It's removable

[lsdyi]

Good afternoon ☕️ @kdy1 I've removed the redundant clone() method and collected list elements in a specific new for loop. Could you please help me check whether the code meets expectation?

[kdy1]

swc-bump:

• swc_ecma_transforms_compat