fix(es/compat): Visit transformed expression in optional chaining pass #7614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
commented
Jul 3, 2023
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
jridgewell
suggested changes
Jul 3, 2023
Comment on lines
1
to
16
| const ModalInner = ({ data }) => { | ||
| return ( | ||
| <Album | ||
| data={(qcData?.flawImageList || [])?.map(src => ({ | ||
| url: src, | ||
| describe: qcData?.flawDesc | ||
| }))} | ||
| showIndicators | ||
| useSafeAreaBottom | ||
| showDescription | ||
| current={current} | ||
| > | ||
| test | ||
| </Album> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Nit: this is enough to trigger the bug:
Suggested change
| const ModalInner = ({ data }) => { | |
| return ( | |
| <Album | |
| data={(qcData?.flawImageList || [])?.map(src => ({ | |
| url: src, | |
| describe: qcData?.flawDesc | |
| }))} | |
| showIndicators | |
| useSafeAreaBottom | |
| showDescription | |
| current={current} | |
| > | |
| test | |
| </Album> | |
| ) | |
| } | |
| (qcData?.flawImageList || [])?.map() |
| @@ -64,6 +64,7 @@ impl VisitMut for OptChaining { | |||
| Expr::OptChain(v) => { | |||
| let data = self.gather(v.take(), vec![]); | |||
| *e = self.construct(data, false, self.c.no_document_all); | |||
| e.visit_mut_children_with(self); | |||
There was a problem hiding this comment.
We would need the same call for Expr::Unary, but I think the better solution is to fix it at https://github.com/kdy1/swc/blob/9f44d10bb2a28aa7d776c2a4243074e8f59494f7/crates/swc_ecma_transforms_compat/src/es2020/optional_chaining.rs#L207. That'll avoid a repeated iteration of prop and args (we do them during gathering). The only thing I missed was transforming the base
| @@ -8,4 +8,4 @@ var _foo, _a_b_c, _a, _a_b_c_d, _a_b, _a_b_c_d1, _a_b_c1, _orders, _orders_, _or | |||
| orders[(_client = client) === null || _client === void 0 ? void 0 : _client.key].price; | |||
| (_orders_client_key = orders[client.key]) === null || _orders_client_key === void 0 ? void 0 : _orders_client_key.price; | |||
| (0, (_a1 = a) === null || _a1 === void 0 ? void 0 : _a1.b).c; | |||
| (0, (_c = (0, a?.b).c) === null || _c === void 0 ? void 0 : _c.d).e; | |||
jridgewell
previously approved these changes
Jul 4, 2023
swc-bot
reviewed
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: