Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix a bug about eval of name mangler #7615

Merged
merged 91 commits into from
Jul 18, 2023
Merged

fix(es/minifier): Fix a bug about eval of name mangler #7615

merged 91 commits into from
Jul 18, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 3, 2023 •
edited

@kdy1 kdy1 added this to the Planned milestone Jul 3, 2023
@kdy1 kdy1 self-assigned this Jul 3, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Fix outstatic fix(es/minifier): Fix a bug about eval of name mangler Jul 5, 2023
kdy1
kdy1 commented Jul 5, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug about eval of name mangler fix(es/minifier): Don't invoke arrow functions if eval exists Jul 5, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Don't invoke arrow functions if eval exists fix(es/minifier): Fix a bug about eval of name mangler Jul 5, 2023
@kdy1 kdy1 requested a review from jridgewell July 5, 2023 03:45
@kdy1 kdy1 marked this pull request as ready for review July 5, 2023 03:45
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 5, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 5, 2023
View reviewed changes
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug about eval of name mangler fix(es/minifier): Fix a bug about eval of name mangler Jul 5, 2023
@kdy1 kdy1 marked this pull request as draft July 5, 2023 03:53
@kdy1 kdy1 marked this pull request as ready for review July 5, 2023 03:58
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 5, 2023
View reviewed changes
@avitorio avitorio mentioned this pull request Jul 10, 2023
Closed
jridgewell
jridgewell suggested changes Jul 14, 2023
View reviewed changes
crates/swc_ecma_minifier/tests/fixture/next/outstatic/1/input.js
@@ -0,0 +1,73 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is too large for me to really understand what's changed, and the diff between this and playground doesn't really help

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments for this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't know the exact cause of the problem.

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2023
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell July 17, 2023 06:28
jridgewell
jridgewell previously approved these changes Jul 17, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) July 18, 2023 00:25
@kdy1 kdy1 dismissed stale reviews from kodiakhq and jridgewell via 9e7fdf2 July 18, 2023 00:28
@kdy1 kdy1 merged commit 6be1f70 into swc-project:main Jul 18, 2023
128 checks passed
@kdy1 kdy1 deleted the minifier-outstatic branch July 18, 2023 01:09
@kdy1 kdy1 modified the milestones: Planned, v1.3.70 Jul 18, 2023
@kdy1 kdy1 mentioned this pull request Jul 18, 2023
Closed
@h-a-n-a h-a-n-a mentioned this pull request Jul 18, 2023
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.70
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @jridgewell