Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/preset-env): Update compat data #7630

Merged
merged 7 commits into from
Jul 7, 2023
Merged

feat(es/preset-env): Update compat data #7630

merged 7 commits into from
Jul 7, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 5, 2023 •
edited

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jul 5, 2023
@kdy1 kdy1 self-assigned this Jul 5, 2023
@kdy1 kdy1 marked this pull request as ready for review July 5, 2023 07:03
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 5, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) July 5, 2023 07:04
kdy1
kdy1 commented Jul 5, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_preset_env

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 5, 2023
View reviewed changes
@zloirock
Copy link

zloirock commented Jul 5, 2023

For example, a few lines away, I see also es.symbol.matcher esnext.symbol.matcher. It could be good to validate all module names.

@HomyeeKing
Copy link

I tried to make a fix myself, but can't pass the test, so I give up to send a pr, HomyeeKing/swc@main...fix/corejs

can't use options.json?

swc-bot
swc-bot reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 7e9e84e into swc-project:main Jul 7, 2023
249 checks passed
@kdy1 kdy1 deleted the corejs branch July 7, 2023 02:57
@kdy1 kdy1 modified the milestones: Planned, v1.3.69 Jul 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.69
Development

Successfully merging this pull request may close these issues.

import wrong core-js module
4 participants
@kdy1 @zloirock @HomyeeKing @swc-bot