Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Drop recursively used var declaration #7649

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat(es/minifier): Drop recursively used var declaration #7649

merged 1 commit into from
Jul 14, 2023

Conversation

Austaras
Copy link
Member

Description:

This is only possible if we completely ignore TDZ error, but since this behavior matches terser, I believe it's fine.

BREAKING CHANGE:

Related issue (if exists):
#7641

@kdy1 kdy1 requested a review from jridgewell July 13, 2023 02:03
@kdy1 kdy1 added this to the Planned milestone Jul 13, 2023
kdy1
kdy1 previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_usage_analyzer

@kdy1 kdy1 merged commit 04b0f6d into swc-project:main Jul 14, 2023
127 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.70 Jul 18, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@kdy1 kdy1 kdy1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.70
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Austaras @jridgewell @kdy1