fix(es/typescript): Fix handling of optional chaining #7660

kdy1 · 2023-07-14T03:15:05Z

Description:

Related issue:

Closes Unexpected behaviour of optional chaining lead to reading property of 'undefined' #7659.

kdy1 · 2023-07-18T05:30:10Z

Problematic:

[crates/swc_ecma_transforms_typescript/src/strip.rs:452] &expr = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:477] &obj = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:477] &obj = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)

kdy1 · 2023-07-18T05:35:58Z

Wanted:

[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                27,
            ),
            ctxt: #0,
        },
        optional: false,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        27,
                    ),
                    ctxt: #0,
                },
                obj: OptChain(
                    OptChainExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        optional: true,
                        base: Member(
                            MemberExpr {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                obj: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                21,
                                            ),
                                            hi: BytePos(
                                                22,
                                            ),
                                            ctxt: #2,
                                        },
                                        sym: Atom('a' type=static),
                                        optional: false,
                                    },
                                ),
                                prop: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                24,
                                            ),
                                            hi: BytePos(
                                                25,
                                            ),
                                            ctxt: #0,
                                        },
                                        sym: Atom('b' type=static),
                                        optional: false,
                                    },
                                ),
                            },
                        ),
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                26,
                            ),
                            hi: BytePos(
                                27,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('c' type=inline),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                27,
            ),
            ctxt: #0,
        },
        optional: false,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        27,
                    ),
                    ctxt: #0,
                },
                obj: OptChain(
                    OptChainExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        optional: true,
                        base: Member(
                            MemberExpr {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                obj: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                21,
                                            ),
                                            hi: BytePos(
                                                22,
                                            ),
                                            ctxt: #2,
                                        },
                                        sym: Atom('a' type=static),
                                        optional: false,
                                    },
                                ),
                                prop: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                24,
                                            ),
                                            hi: BytePos(
                                                25,
                                            ),
                                            ctxt: #0,
                                        },
                                        sym: Atom('b' type=static),
                                        optional: false,
                                    },
                                ),
                            },
                        ),
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                26,
                            ),
                            hi: BytePos(
                                27,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('c' type=inline),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                27,
            ),
            ctxt: #0,
        },
        optional: false,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        27,
                    ),
                    ctxt: #0,
                },
                obj: OptChain(
                    OptChainExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        optional: true,
                        base: Member(
                            MemberExpr {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                obj: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                21,
                                            ),
                                            hi: BytePos(
                                                22,
                                            ),
                                            ctxt: #2,
                                        },
                                        sym: Atom('a' type=static),
                                        optional: false,
                                    },
                                ),
                                prop: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                24,
                                            ),
                                            hi: BytePos(
                                                25,
                                            ),
                                            ctxt: #0,
                                        },
                                        sym: Atom('b' type=static),
                                        optional: false,
                                    },
                                ),
                            },
                        ),
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                26,
                            ),
                            hi: BytePos(
                                27,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('c' type=inline),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                27,
            ),
            ctxt: #0,
        },
        optional: false,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        27,
                    ),
                    ctxt: #0,
                },
                obj: OptChain(
                    OptChainExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        optional: true,
                        base: Member(
                            MemberExpr {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                obj: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                21,
                                            ),
                                            hi: BytePos(
                                                22,
                                            ),
                                            ctxt: #2,
                                        },
                                        sym: Atom('a' type=static),
                                        optional: false,
                                    },
                                ),
                                prop: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                24,
                                            ),
                                            hi: BytePos(
                                                25,
                                            ),
                                            ctxt: #0,
                                        },
                                        sym: Atom('b' type=static),
                                        optional: false,
                                    },
                                ),
                            },
                        ),
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                26,
                            ),
                            hi: BytePos(
                                27,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('c' type=inline),
                        optional: false,
                    },
                ),
            },
        ),
    },
)

Problematic:

[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = Member(
    MemberExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                28,
            ),
            ctxt: #0,
        },
        obj: TsNonNull(
            TsNonNullExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        26,
                    ),
                    ctxt: #0,
                },
                expr: OptChain(
                    OptChainExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        optional: true,
                        base: Member(
                            MemberExpr {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                obj: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                21,
                                            ),
                                            hi: BytePos(
                                                22,
                                            ),
                                            ctxt: #2,
                                        },
                                        sym: Atom('a' type=static),
                                        optional: false,
                                    },
                                ),
                                prop: Ident(
                                    Ident {
                                        span: Span {
                                            lo: BytePos(
                                                24,
                                            ),
                                            hi: BytePos(
                                                25,
                                            ),
                                            ctxt: #0,
                                        },
                                        sym: Atom('b' type=static),
                                        optional: false,
                                    },
                                ),
                            },
                        ),
                    },
                ),
            },
        ),
        prop: Ident(
            Ident {
                span: Span {
                    lo: BytePos(
                        27,
                    ),
                    hi: BytePos(
                        28,
                    ),
                    ctxt: #0,
                },
                sym: Atom('c' type=inline),
                optional: false,
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = TsNonNull(
    TsNonNullExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                26,
            ),
            ctxt: #0,
        },
        expr: OptChain(
            OptChainExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                optional: true,
                base: Member(
                    MemberExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        obj: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        22,
                                    ),
                                    ctxt: #2,
                                },
                                sym: Atom('a' type=static),
                                optional: false,
                            },
                        ),
                        prop: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        24,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                sym: Atom('b' type=static),
                                optional: false,
                            },
                        ),
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = Member(
    MemberExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                28,
            ),
            ctxt: #0,
        },
        obj: OptChain(
            OptChainExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                optional: true,
                base: Member(
                    MemberExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        obj: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        22,
                                    ),
                                    ctxt: #2,
                                },
                                sym: Atom('a' type=static),
                                optional: false,
                            },
                        ),
                        prop: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        24,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                sym: Atom('b' type=static),
                                optional: false,
                            },
                        ),
                    },
                ),
            },
        ),
        prop: Ident(
            Ident {
                span: Span {
                    lo: BytePos(
                        27,
                    ),
                    hi: BytePos(
                        28,
                    ),
                    ctxt: #0,
                },
                sym: Atom('c' type=inline),
                optional: false,
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = Member(
    MemberExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                28,
            ),
            ctxt: #0,
        },
        obj: OptChain(
            OptChainExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                optional: true,
                base: Member(
                    MemberExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        obj: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        22,
                                    ),
                                    ctxt: #2,
                                },
                                sym: Atom('a' type=static),
                                optional: false,
                            },
                        ),
                        prop: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        24,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                sym: Atom('b' type=static),
                                optional: false,
                            },
                        ),
                    },
                ),
            },
        ),
        prop: Ident(
            Ident {
                span: Span {
                    lo: BytePos(
                        27,
                    ),
                    hi: BytePos(
                        28,
                    ),
                    ctxt: #0,
                },
                sym: Atom('c' type=inline),
                optional: false,
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2084] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = OptChain(
    OptChainExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                25,
            ),
            ctxt: #0,
        },
        optional: true,
        base: Member(
            MemberExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                obj: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                22,
                            ),
                            ctxt: #2,
                        },
                        sym: Atom('a' type=static),
                        optional: false,
                    },
                ),
                prop: Ident(
                    Ident {
                        span: Span {
                            lo: BytePos(
                                24,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        sym: Atom('b' type=static),
                        optional: false,
                    },
                ),
            },
        ),
    },
)
[crates/swc_ecma_transforms_typescript/src/strip.rs:2096] &*n = Member(
    MemberExpr {
        span: Span {
            lo: BytePos(
                21,
            ),
            hi: BytePos(
                28,
            ),
            ctxt: #0,
        },
        obj: OptChain(
            OptChainExpr {
                span: Span {
                    lo: BytePos(
                        21,
                    ),
                    hi: BytePos(
                        25,
                    ),
                    ctxt: #0,
                },
                optional: true,
                base: Member(
                    MemberExpr {
                        span: Span {
                            lo: BytePos(
                                21,
                            ),
                            hi: BytePos(
                                25,
                            ),
                            ctxt: #0,
                        },
                        obj: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        21,
                                    ),
                                    hi: BytePos(
                                        22,
                                    ),
                                    ctxt: #2,
                                },
                                sym: Atom('a' type=static),
                                optional: false,
                            },
                        ),
                        prop: Ident(
                            Ident {
                                span: Span {
                                    lo: BytePos(
                                        24,
                                    ),
                                    hi: BytePos(
                                        25,
                                    ),
                                    ctxt: #0,
                                },
                                sym: Atom('b' type=static),
                                optional: false,
                            },
                        ),
                    },
                ),
            },
        ),
        prop: Ident(
            Ident {
                span: Span {
                    lo: BytePos(
                        27,
                    ),
                    hi: BytePos(
                        28,
                    ),
                    ctxt: #0,
                },
                sym: Atom('c' type=inline),
                optional: false,
            },
        ),
    },
)

kdy1

swc-bump:

swc_ecma_transforms_typescript

swc-bot

Automated review comment generated by auto-rebase script

kdy1

reset ci

kdy1 added 2 commits July 14, 2023 11:40

Add a test

de68edf

Adjust

462f4f9

kdy1 added this to the Planned milestone Jul 14, 2023

kdy1 self-assigned this Jul 14, 2023

Add a test case for comparison

e0ea985

kdy1 added 2 commits July 18, 2023 14:33

dbg

7b91467

Add a test case for comparison

d25df0d

kdy1 added 4 commits July 21, 2023 14:46

Move code

5661192

Remove dbg

e2d1ff8

Update test refs

3e2d161

call

e338c6a

kdy1 commented Jul 21, 2023

View reviewed changes

kdy1 marked this pull request as ready for review July 21, 2023 05:52

kdy1 enabled auto-merge (squash) July 21, 2023 05:52

kodiakhq bot approved these changes Jul 21, 2023

View reviewed changes

Merge branch 'main' into issue-7659

9ab0066

swc-bot reviewed Jul 24, 2023

View reviewed changes

kdy1 commented Jul 24, 2023

View reviewed changes

kdy1 merged commit c017874 into swc-project:main Jul 24, 2023
248 checks passed

kdy1 deleted the issue-7659 branch July 24, 2023 04:37

kdy1 modified the milestones: Planned, v1.3.71 Jul 25, 2023

swc-project locked as resolved and limited conversation to collaborators Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(es/typescript): Fix handling of optional chaining #7660

fix(es/typescript): Fix handling of optional chaining #7660

kdy1 commented Jul 14, 2023

kdy1 commented Jul 18, 2023 •

edited

kdy1 commented Jul 18, 2023 •

edited

kdy1 left a comment

swc-bot left a comment

kdy1 left a comment

fix(es/typescript): Fix handling of optional chaining #7660

fix(es/typescript): Fix handling of optional chaining #7660

Conversation

kdy1 commented Jul 14, 2023

kdy1 commented Jul 18, 2023 • edited

kdy1 commented Jul 18, 2023 • edited

kdy1 left a comment

Choose a reason for hiding this comment

swc-bot left a comment

Choose a reason for hiding this comment

kdy1 left a comment

Choose a reason for hiding this comment

kdy1 commented Jul 18, 2023 •

edited

kdy1 commented Jul 18, 2023 •

edited