Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/modules): Preserve attribute selectors used with :global #7670

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(css/modules): Preserve attribute selectors used with :global #7670

merged 1 commit into from
Jul 19, 2023

Conversation

Thiry1
Copy link
Contributor

@Thiry1 Thiry1 commented Jul 18, 2023 •
edited by kdy1

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1 kdy1 added this to the Planned milestone Jul 19, 2023
kdy1
kdy1 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_css_modules

@kdy1 kdy1 changed the title fix(css-modules): Attribute Selector is disappear when using :global and Attribute Selector at the same time fix(css/modules): Preserve attr selectors used with :global Jul 19, 2023
@kdy1 kdy1 changed the title fix(css/modules): Preserve attr selectors used with :global fix(css/modules): Preserve attribute selectors used with :global Jul 19, 2023
@kdy1 kdy1 enabled auto-merge (squash) July 19, 2023 05:20
@kdy1 kdy1 merged commit 11b4679 into swc-project:main Jul 19, 2023
128 checks passed
@Thiry1 Thiry1 deleted the fix/css-atribute-selector-with-global branch July 19, 2023 05:20
@kdy1 kdy1 modified the milestones: Planned, v1.3.71 Jul 25, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.71
Development

Successfully merging this pull request may close these issues.

[css modules] Using :global and Attribute Selector at the same time breaks output
3 participants
@Thiry1 @CLAassistant @kdy1