Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(es/parser): Make stacker an optional dependency #7720

Merged
merged 2 commits into from
Jul 28, 2023
Merged

refactor(es/parser): Make stacker an optional dependency #7720

merged 2 commits into from
Jul 28, 2023

Conversation

SkaillZ
Copy link
Contributor

@SkaillZ SkaillZ commented Jul 27, 2023 •
edited by kdy1

Description:

Makes the stacker dependency optional (enabled by default). This allows disabling the dependency e.g. due to one of the reasons outlined in #7719.

Related issue (if exists):
Closes #7719

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kdy1
kdy1 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 changed the title feat(parser): make stacker an optional dependency refactor(es/parser): Make stacker an optional dependency Jul 28, 2023
@kdy1 kdy1 added this to the Planned milestone Jul 28, 2023
@kdy1 kdy1 enabled auto-merge (squash) July 28, 2023 03:30
swc-bot
swc-bot reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 864bdef into swc-project:main Jul 28, 2023
249 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.72 Jul 28, 2023
kdy1 pushed a commit to kdy1/swc that referenced this pull request Aug 15, 2023
@SkaillZ @kdy1
refactor(es/parser): Make stacker an optional dependency (swc-proje…
646578c 
…ct#7720)
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.72
Development

Successfully merging this pull request may close these issues.

Make stacker an optional dependency of swc_ecma_parser
5 participants
@SkaillZ @CLAassistant @kdy1 @swc-bot @rebu-dt