Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/module): Fix handling of continuous assignments in systemjs #7741

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix(es/module): Fix handling of continuous assignments in systemjs #7741

merged 4 commits into from
Aug 3, 2023

Conversation

thy486
Copy link
Contributor

@thy486 thy486 commented Aug 2, 2023

Description:

Fix transpile the continuous assignment code like d.a = d.b = d.c = d.d = ... = void 0; to SystemJS may cause Infinite loop.

Related issue:

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_transforms_module

crates/swc_ecma_transforms_module/src/system_js.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Aug 2, 2023
@kdy1 kdy1 changed the title fix: SystemJS transpile continuous assignment code fix(es/module): Fix handling of continuous assignments in systemjs Aug 3, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 3, 2023 02:06
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit f713f6a into swc-project:main Aug 3, 2023
249 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.75 Aug 8, 2023
kdy1 pushed a commit to kdy1/swc that referenced this pull request Aug 15, 2023
…wc-project#7741)

**Description:**

Fix transpile the continuous assignment code like `d.a = d.b = d.c = d.d = ... = void 0;` to SystemJS may cause Infinite loop.

**Related issue:**

 - Closes swc-project#7143.
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop when transpile to SystemJs module.
5 participants