fix(es/minifier): Abort seq inliner if a same var is defined in outer scope #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austaras
commented
Aug 7, 2023
| usage.ref_count += 1; | ||
| } | ||
| self.data.vars.insert((id.0, *ctx), usage); | ||
| } |
There was a problem hiding this comment.
The improvement of output come from here.
…er function scope
jridgewell
approved these changes
Aug 9, 2023
kdy1
changed the title
kdy1
changed the title
swc-bot
reviewed
Aug 9, 2023
kdy1
pushed a commit
to kdy1/swc
that referenced
this pull request
Aug 15, 2023
… scope (swc-project#7772) **Description:** The algorithm here is directly copied from terser, I don't if it's correct or can be improved, but it does fix the issue. **Related issue:** - Closes swc-project#7749
kdy1
pushed a commit
that referenced
this pull request
Aug 17, 2023
…ned (#7804) **Description:** It turns out that the original implementation of `infect`is incomplete because it cannot cover function param, and the new implementation introduced in #7772 is redundant because what [terser](https://github.com/terser/terser/blob/master/lib/compress/tighten-body.js#L909C18-L909C28) do is basically checking `fn_local` **Related issue:** - Closes #7784
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The algorithm here is directly copied from terser, I don't if it's correct or can be improved, but it does fixes the issue.
Related issue: