refactor(es/parser): Don't attempt to handle shebangs in read_token_number_sign
#7803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
read_token_number_sign
kdy1
approved these changes
Aug 14, 2023
kdy1
pushed a commit
to kdy1/swc
that referenced
this pull request
Aug 15, 2023
…number_sign` (swc-project#7803) bump() has a safety invariant that there must be input in the buffer to read (See swc-project#7709). This function as currently written calls `bump()` after calling `read_token_interpreter()`, which *may* have exhausted the buffer already in the specific case that it is handling a shebang. (The input string `#!/bin/js` with no newline is sufficient to cause UB here) Fortunately, shebangs never reach this function, due to `read_shebang`! Hurray! It's cleaner to not attempt to handle shebangs here when this code path will never be reached, and use a debug assertion to ensure that we're not dealing with shebangs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump() has a safety invariant that there must be input in the buffer to read (See #7709).
This function as currently written calls
bump()after callingread_token_interpreter(), which may have exhausted the buffer already in the specific case that it is handling a shebang. (The input string#!/bin/jswith no newline is sufficient to cause UB here)Fortunately, shebangs never reach this function, due to
read_shebang! Hurray!It's cleaner to not attempt to handle shebangs here when this code path will never be reached, and use a debug assertion to ensure that we're not dealing with shebangs.