Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/ast): Expose Archived types #7811

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

JQuezada0
Copy link
Contributor

@JQuezada0 JQuezada0 commented Aug 15, 2023

Description:

For crates using both rkyv and swc, where ast nodes from swc_ecma_ast are included in data that's serialized with rkyv, it's difficult to access the archived data from the archived ast nodes since the types are private.

More context in the issue.

Related issue:

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_common

@kdy1 kdy1 changed the title Export Archived types from rkyv::Archive implementations feat(es/ast): Expose Archived types Aug 15, 2023
@kdy1 kdy1 added this to the Planned milestone Aug 15, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 15, 2023 14:35
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

ss

@kdy1 kdy1 merged commit 478fa47 into swc-project:main Aug 16, 2023
127 checks passed
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Export Archived types from rkyv::Archive implementations
4 participants