fix(es/codegen): Add quotes to property names when ascii_only is true
#7820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
ascii_onlyascii_only is true
kdy1
changed the title
ascii_only is trueascii_only is true
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
swc-bot
reviewed
Aug 16, 2023
jridgewell
reviewed
Aug 16, 2023
| export default { | ||
| \u3131: '\u11B0', | ||
| "\u3131": '\u11B0', |
There was a problem hiding this comment.
Nit: This is actually fine, \u escapes are legal. It's just \x escapes that aren't.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: