refactor(es/minifier): Remove mutated and mutation_by_call_count
#7890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austaras
commented
Aug 29, 2023
| @@ -323,7 +322,7 @@ impl Optimizer<'_> { | |||
| && usage.declared | |||
| && may_remove | |||
| && !usage.reassigned | |||
| && (usage.can_inline_var() || usage.is_mutated_only_by_one_call()) | |||
| && usage.assign_count == 0 | |||
There was a problem hiding this comment.
There's no need to check if a used only once var is mutated -- we inline it anyway.
Austaras
commented
Aug 29, 2023
| pub(crate) fn is_infected(&self) -> bool { | ||
| !self.infects_to.is_empty() | ||
| } | ||
|
|
||
| pub(crate) fn can_inline_var(&self) -> bool { | ||
| !self.mutated || (self.assign_count == 0 && !self.reassigned) |
There was a problem hiding this comment.
This becomes
!self.mutated() || (self.assign_count == 0 && !self.reassigned)which is
!(self.assign_count > 0 || self.has_property_mutation) || (self.assign_count == 0 && !self.reassigned)and thus can be simplified into
usage.assign_count == 0 && (!usage.has_property_mutation || !usage.reassigned)
kdy1
approved these changes
Aug 30, 2023
jridgewell
approved these changes
Aug 30, 2023
kdy1
changed the title
mutated and mutation_by_call_countmutated and mutation_by_call_count
swc-bot
reviewed
Aug 30, 2023
kdy1
added a commit
that referenced
this pull request
Sep 25, 2023
**Description:** x-ref: https://vercel.slack.com/archives/C02HY34AKME/p1695334071194139 Reproduction: https://github.com/kdy1/repro-test-mdx-korean Regression of next.js: `v13.4.11`(swc_core@v0.79.13) => `v13.5.2` (swc_core@v0.83.12) - `next@v13.4.19` works (swc_core@v0.79.59) - `next@v13.4.20-canary.3` works (swc_core@v0.79.70) - **`next@v13.4.20-canary.32` fails** (swc_core@v0.83.12) Commit range: 662f236...e67bf05 - `swc_core@v0.79.70`: 662f236 - `swc_core@v0.83.12`: e67bf05 Diff: https://gist.github.com/kdy1/047e7e5537c34180d446cb3d5b95fce8 --- I did more investigation by monkey-patching the `next` package. `.minify()` resolved without an exception. It means that `.minify()` is producing an invalid ES code. So... candidates are - #7890 - #7876 - #7858 - #7856 - #7853 - #7832
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
mutatedcan be seen as a combination ofreassignedandhas_property_mutation, andmutation_by_call_countis simply useless.