Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/module): Don't create absolute paths for jsc.paths on Windows #7892

Merged
merged 16 commits into from
Aug 30, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 30, 2023

@kdy1 kdy1 added this to the Planned milestone Aug 30, 2023
@kdy1 kdy1 self-assigned this Aug 30, 2023
@kdy1 kdy1 changed the title fix(es/module): Don't use absolute paths on Windows fix(es/module): Don't create absolute paths for jsc.paths on Windows Aug 30, 2023
@kdy1 kdy1 marked this pull request as ready for review August 30, 2023 08:17
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 30, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 30, 2023 08:17
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc

@kdy1 kdy1 merged commit 5fbc251 into swc-project:main Aug 30, 2023
128 checks passed
@kdy1 kdy1 deleted the issue-7806 branch August 30, 2023 10:11
@kdy1 kdy1 modified the milestones: Planned, v1.3.81 Aug 30, 2023
@wp-harm
Copy link

wp-harm commented Aug 30, 2023

Great work @kdy1, from the looks of it the culprit has been detected and solved, can't wait to test it! 💪

@viniciussantos45
Copy link

Perfect !!

It's working now

@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Imports use absolute paths on windows instead of relative
3 participants