Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/codegen): Add an option to print assert for import attributes #7914

Merged
merged 22 commits into from
Sep 5, 2023
Merged

feat(es/codegen): Add an option to print assert for import attributes #7914

merged 22 commits into from
Sep 5, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 5, 2023 •
edited

Description:

  • jsc.experimental.keepImportAssertions is renamed to jsc.experimental.keepImportAttributes.
  • jsc.experimental.emitAssertForImportAttributes is added.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Sep 5, 2023
@kdy1 kdy1 self-assigned this Sep 5, 2023
@kdy1 kdy1 marked this pull request as ready for review September 5, 2023 10:56
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 5, 2023
View reviewed changes
@kdy1 kdy1 changed the title feat(es): Add an experimental option to print asserts for import attributes feat(es): Add an option to print assert for import attributes Sep 5, 2023
@kdy1 kdy1 changed the title feat(es): Add an option to print assert for import attributes feat(es/codegen): Add an option to print assert for import attributes Sep 5, 2023
@kdy1 kdy1 enabled auto-merge (squash) September 5, 2023 10:56
kdy1
kdy1 commented Sep 5, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser --breaking

@kdy1 kdy1 disabled auto-merge September 5, 2023 10:57
@kdy1 kdy1 enabled auto-merge (squash) September 5, 2023 10:58
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 5, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 5, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 5, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 5, 2023
View reviewed changes
@kdy1 kdy1 disabled auto-merge September 5, 2023 12:24
@kdy1 kdy1 merged commit ee75756 into swc-project:main Sep 5, 2023
127 of 128 checks passed
@kdy1 kdy1 deleted the issue-7908 branch September 5, 2023 12:24
@kdy1 kdy1 modified the milestones: Planned, v1.3.83 Sep 7, 2023
@felixh10r felixh10r mentioned this pull request Sep 7, 2023
Closed
@meabed meabed mentioned this pull request Sep 7, 2023
Closed
@billykwok billykwok mentioned this pull request Sep 7, 2023
Closed
@isaacs isaacs mentioned this pull request Sep 7, 2023
Closed
coderbyheart added a commit to hello-nrfcloud/proto that referenced this pull request Sep 12, 2023
@coderbyheart
fix: emit assert for import assertions
dae19b5 
Use the new SWC configuration settings added in swc-project/swc#7914
@coderbyheart coderbyheart mentioned this pull request Sep 12, 2023
Merged
coderbyheart added a commit to hello-nrfcloud/proto that referenced this pull request Sep 12, 2023
@coderbyheart
fix: emit assert for import assertions
3723055 
Use the new SWC configuration settings added in swc-project/swc#7914
coderbyheart added a commit to hello-nrfcloud/proto that referenced this pull request Sep 12, 2023
@coderbyheart
fix: emit assert for import assertions
2c50f8a 
Use the new SWC configuration settings added in swc-project/swc#7914
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.83
Development

Successfully merging this pull request may close these issues.

Import assertions are blanket converted to import attributes
1 participant
@kdy1