Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/modules): Support composes when using multiple subclass selectors #7949

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix(css/modules): Support composes when using multiple subclass selectors #7949

merged 2 commits into from
Sep 14, 2023

Conversation

aweary
Copy link
Contributor

@aweary aweary commented Sep 13, 2023 •
edited

Resolves #7948

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aweary aweary mentioned this pull request Sep 13, 2023
Closed
@aweary aweary changed the title [css/modules] failing test for composes with multiple selectors [css/modules] support composes when using multiple subclass selectors Sep 13, 2023
@aweary aweary marked this pull request as ready for review September 13, 2023 14:56
kdy1
kdy1 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_modules

@kdy1 kdy1 changed the title [css/modules] support composes when using multiple subclass selectors fix(css/modules): Support composes when using multiple subclass selectors Sep 14, 2023
@kdy1 kdy1 enabled auto-merge (squash) September 14, 2023 02:14
@kdy1 kdy1 added this to the Planned milestone Sep 14, 2023
@kdy1 kdy1 merged commit 05ca19b into swc-project:main Sep 14, 2023
130 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.85 Sep 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.85
Development

Successfully merging this pull request may close these issues.

[css/modules] composes fails when using multiple selectors
3 participants
@aweary @CLAassistant @kdy1