Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(css/parser): Use AtomStore #8238

Merged
merged 6 commits into from Nov 7, 2023
Merged

perf(css/parser): Use AtomStore #8238

merged 6 commits into from Nov 7, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 7, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Nov 7, 2023
@kdy1 kdy1 self-assigned this Nov 7, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


swc-bump:

  • swc_css_parser

@kdy1 kdy1 marked this pull request as ready for review November 7, 2023 09:19
@kdy1 kdy1 enabled auto-merge (squash) November 7, 2023 09:19
@kdy1
Copy link
Member Author

kdy1 commented Nov 7, 2023

Preivous


Benchmarking css/parser/bootstrap_5_1_3: Analyzing
css/parser/bootstrap_5_1_3
                        time:   [8.7492 ms 8.7695 ms 8.7969 ms]
                        change: [-5.3498% -4.4809% -3.7782%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 16 outliers among 100 measurements (16.00%)
  5 (5.00%) high mild
  11 (11.00%) high severe

Benchmarking css/parser/foundation_6_7_4
Benchmarking css/parser/foundation_6_7_4: Warming up for 3.0000 s
Benchmarking css/parser/foundation_6_7_4: Collecting 100 samples in estimated 5.1061 s (700 iterations)
Benchmarking css/parser/foundation_6_7_4: Analyzing
css/parser/foundation_6_7_4
                        time:   [7.1341 ms 7.1420 ms 7.1515 ms]
Found 12 outliers among 100 measurements (12.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  8 (8.00%) high severe

Benchmarking css/parser/tailwind_3_1_1
Benchmarking css/parser/tailwind_3_1_1: Warming up for 3.0000 s

Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.1s, enable flat sampling, or reduce sample count to 50.
Benchmarking css/parser/tailwind_3_1_1: Collecting 100 samples in estimated 7.1011 s (5050 iterations)
Benchmarking css/parser/tailwind_3_1_1: Analyzing
css/parser/tailwind_3_1_1
                        time:   [1.3845 ms 1.3864 ms 1.3887 ms]
Found 10 outliers among 100 measurements (10.00%)
  6 (6.00%) high mild
  4 (4.00%) high severe

New

css/parser/bootstrap_5_1_3
                        time:   [8.1769 ms 8.1991 ms 8.2242 ms]
                        change: [+0.2133% +0.5588% +0.9283%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 11 outliers among 100 measurements (11.00%)
  8 (8.00%) high mild
  3 (3.00%) high severe

Benchmarking css/parser/foundation_6_7_4
Benchmarking css/parser/foundation_6_7_4: Warming up for 3.0000 s
Benchmarking css/parser/foundation_6_7_4: Collecting 100 samples in estimated 5.3093 s (800 iterations)
Benchmarking css/parser/foundation_6_7_4: Analyzing
css/parser/foundation_6_7_4
                        time:   [6.6579 ms 6.6715 ms 6.6875 ms]
Found 12 outliers among 100 measurements (12.00%)
  7 (7.00%) high mild
  5 (5.00%) high severe

Benchmarking css/parser/tailwind_3_1_1
Benchmarking css/parser/tailwind_3_1_1: Warming up for 3.0000 s

Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 6.5s, enable flat sampling, or reduce sample count to 60.
Benchmarking css/parser/tailwind_3_1_1: Collecting 100 samples in estimated 6.4885 s (5050 iterations)
Benchmarking css/parser/tailwind_3_1_1: Analyzing
css/parser/tailwind_3_1_1
                        time:   [1.2794 ms 1.2815 ms 1.2839 ms]
Found 13 outliers among 100 measurements (13.00%)
  6 (6.00%) high mild
  7 (7.00%) high severe

@kdy1 kdy1 disabled auto-merge November 7, 2023 12:38
@kdy1 kdy1 merged commit a3c03b3 into swc-project:main Nov 7, 2023
140 checks passed
@kdy1 kdy1 deleted the css-atom branch November 7, 2023 12:38
@kdy1 kdy1 modified the milestones: Planned, v1.3.97 Nov 9, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.97 Nov 20, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make CSS parser use AtomStore API
1 participant