Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Enable seq inliner for const declarations #8255

Merged
merged 2 commits into from Nov 13, 2023

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Nov 9, 2023

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Nov 9, 2023
@kdy1 kdy1 self-assigned this Nov 9, 2023
});
const _interop_require_default = require("@swc/helpers/_/_interop_require_default"), _a = /*#__PURE__*/ _interop_require_default._(require("a"));
(0, _a.default)();
}), (0, /*#__PURE__*/ require("@swc/helpers/_/_interop_require_default")._(require("a")).default)();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from the original code, but it looks like a bugfix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as old code. both _interop_require_default and _a are inlined.

kdy1
kdy1 previously approved these changes Nov 10, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_minifier

@kdy1
Copy link
Member

kdy1 commented Nov 10, 2023

Can you update the test references? (I think those are unrelated to this PR, though)

@kdy1 kdy1 changed the title fix(es/minifier): Enable seq inliner for const decl fix(es/minifier): Enable seq inliner for const declarations Nov 13, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 13, 2023 03:12
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit ebcd825 into swc-project:main Nov 13, 2023
143 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants