Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Respect pure_funcs for tagged tpls #8280

Merged
merged 7 commits into from Nov 14, 2023
Merged

fix(es/minifier): Respect pure_funcs for tagged tpls #8280

merged 7 commits into from Nov 14, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 13, 2023

@kdy1 kdy1 added this to the Planned milestone Nov 13, 2023
@kdy1 kdy1 self-assigned this Nov 13, 2023
@kdy1 kdy1 requested a review from jridgewell November 13, 2023 22:19
@kdy1 kdy1 marked this pull request as ready for review November 13, 2023 23:02
@kdy1 kdy1 requested a review from a team as a code owner November 13, 2023 23:02
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 13, 2023
View reviewed changes
kdy1
kdy1 commented Nov 13, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 dismissed kodiakhq’s stale review November 13, 2023 23:08

I don't need this anymore :)

@kdy1 kdy1 enabled auto-merge (squash) November 14, 2023 15:59
swc-bot
swc-bot reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 1ccfc07 into swc-project:main Nov 14, 2023
143 checks passed
@kdy1 kdy1 deleted the issue-8275 branch November 14, 2023 19:59
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@Austaras Austaras Austaras approved these changes

@kodiakhq kodiakhq[bot] kodiakhq left review comments

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.

Tagged template literals: minify does not shake pure tag function
3 participants
@kdy1 @Austaras @swc-bot