Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Fix get_ascii_only_ident #8287

Merged
merged 4 commits into from Nov 16, 2023
Merged

fix(es/codegen): Fix get_ascii_only_ident #8287

merged 4 commits into from Nov 16, 2023
+41 −27

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 15, 2023

@kdy1 kdy1 added this to the Planned milestone Nov 15, 2023
@kdy1 kdy1 self-assigned this Nov 15, 2023
@kdy1 kdy1 changed the title fix(es/codegen): Fix ascii_only fix(es/codegen): Fix get_ascii_only_ident Nov 15, 2023
@kdy1 kdy1 marked this pull request as ready for review November 15, 2023 04:07
@kdy1 kdy1 requested a review from a team as a code owner November 15, 2023 04:07
kdy1
kdy1 commented Nov 15, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 removed their assignment Nov 15, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 16, 2023 08:25
swc-bot
swc-bot reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 07c8935 into swc-project:main Nov 16, 2023
277 checks passed
@kdy1 kdy1 deleted the issue-8260 branch November 16, 2023 08:50
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@Austaras Austaras Austaras approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

@magic-akari magic-akari Awaiting requested review from magic-akari

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.

minify.format.ascii_only results in invalid escape sequences
3 participants
@kdy1 @Austaras @swc-bot