Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(es): Remove duplicate phf dependency #8294

Merged
merged 2 commits into from Nov 15, 2023

Conversation

dsherret
Copy link
Contributor

Description: Sorry, should have included this in my last PR, but I just noticed this one.

This removes the duplicate phf dependency to align with the version in hstr.

Related issue (if exists): None

@dsherret dsherret requested review from a team as code owners November 15, 2023 22:59
@@ -11,7 +11,7 @@ version = "0.110.29"
bench = false

[dependencies]
phf = { version = "0.10", features = ["macros"] }
phf = { version = "0.11", features = ["macros"] }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See lockfile for difference.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_ext_transforms
  • swc_ecma_transforms_base

@kdy1 kdy1 changed the title fix: Remove duplicate phf dependency build(es): Remove duplicate phf dependency Nov 15, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 15, 2023 23:04
@kdy1 kdy1 added this to the Planned milestone Nov 15, 2023
@kdy1 kdy1 merged commit 25ac679 into swc-project:main Nov 15, 2023
141 of 142 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants