Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/proposal): Improve resolving of design:returntype #8303

Merged
merged 4 commits into from Nov 19, 2023
Merged

fix(es/proposal): Improve resolving of design:returntype #8303

merged 4 commits into from Nov 19, 2023

Conversation

ZakisM
Copy link
Contributor

@ZakisM ZakisM commented Nov 17, 2023 •
edited by kdy1

Description:

Emits 'design:returntype' metadata when using "decoratorMetadata": true.

Related issue:

@ZakisM ZakisM requested a review from a team as a code owner November 17, 2023 21:21
@ZakisM
Copy link
Contributor Author

ZakisM commented Nov 17, 2023

CI failures seem unrelated.

kdy1
kdy1 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_proposal

@kdy1 kdy1 added this to the Planned milestone Nov 19, 2023
@kdy1 kdy1 changed the title fix(ecma/transforms): Resolve undefined 'design:returntype' in Reflec… fix(es/proposal): Improve resolving of design:returntypw Nov 19, 2023
@kdy1 kdy1 changed the title fix(es/proposal): Improve resolving of design:returntypw fix(es/proposal): Improve resolving of design:returntype Nov 19, 2023
@kdy1 kdy1 merged commit fab51e1 into swc-project:main Nov 19, 2023
111 of 144 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 20, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.

Reflect metadata "design:returntype" is undefined
2 participants
@ZakisM @kdy1