Should the optimizer.global.envs type include Record<string, string>?

[davidmurdoch]

optimizer.global.envs type is defined here:

https://github.com/swc-project/swc/blob/9cf91a375bbd87abb16bffa2d6ec44a32059d102/packages/types/index.ts#L868C8-L868C8

I don't know Rust, but with a little intuition and a lot of GPT, I think it should be something like:

-    envs?: string[];
+    envs?: string[] | Record<string, string>;

[davidmurdoch]

Does this look correct? I'll submit a PR if so.

[kdy1]

Yes, it's valid. Thank you in advance!

[davidmurdoch]

Done. Thank you!

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.