Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/quote): Add support for import phase to quote macro #8536

Merged
merged 1 commit into from Jan 22, 2024
Merged

fix(es/quote): Add support for import phase to quote macro #8536

merged 1 commit into from Jan 22, 2024

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Jan 22, 2024 •
edited

Description:

When using quote! to generate import decl, compile error: missing field phase in initializer of 'swc_core::ecma::ast::Import'

BREAKING CHANGE:

Related issue (if exists):

@JSerFeng JSerFeng requested a review from a team as a code owner January 22, 2024 08:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024 •
edited

⚠️ No Changeset found

Latest commit: 5a75fc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JSerFeng JSerFeng marked this pull request as draft January 22, 2024 08:31
@JSerFeng JSerFeng marked this pull request as ready for review January 22, 2024 09:36
kdy1
kdy1 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_quote_macros

@kdy1 kdy1 added this to the Planned milestone Jan 22, 2024
@kdy1 kdy1 enabled auto-merge (squash) January 22, 2024 13:02
@kdy1 kdy1 disabled auto-merge January 22, 2024 13:02
@kdy1 kdy1 changed the title fix: quote macro support import phase fix(es/quote): Add support for import phase to quote macro Jan 22, 2024
@kdy1 kdy1 merged commit 71930ff into swc-project:main Jan 22, 2024
142 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.106 Jan 24, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.106
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JSerFeng @kdy1