Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/decorators): Do not insert duplicate constructors #8631

Merged
merged 4 commits into from Feb 13, 2024
Merged

fix(es/decorators): Do not insert duplicate constructors #8631

merged 4 commits into from Feb 13, 2024
+92 −26

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Feb 12, 2024 •
edited by kdy1

Description:

Doesn't insert a duplicate ctor when the ctor uses overloads in TS.

Related issue:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2024 •
edited

⚠️ No Changeset found

Latest commit: e1ccd27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dsherret dsherret marked this pull request as ready for review February 12, 2024 18:15
@dsherret dsherret requested a review from a team as a code owner February 12, 2024 18:15
@dsherret dsherret mentioned this pull request Feb 12, 2024
Closed
kdy1
kdy1 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_proposal

@kdy1 kdy1 added this to the Planned milestone Feb 13, 2024
@kdy1 kdy1 changed the title fix(es/transforms): do not insert duplicate ctor when using decorators fix(es/decorators): Do not insert duplicate constructors Feb 13, 2024
@kdy1 kdy1 enabled auto-merge (squash) February 13, 2024 02:28
swc-bot
swc-bot reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 21a447f into swc-project:main Feb 13, 2024
277 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.1 Feb 13, 2024
@dsherret dsherret deleted the fix_duplicate_ctor_decorators_overloads branch March 9, 2024 21:27
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Classes with ctor overloads have a duplicate ctor inserted when using decorators
3 participants
@dsherret @kdy1 @swc-bot