Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/compat): Split declaration and init in block-scoping pass #8648

Merged
merged 7 commits into from Feb 20, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 19, 2024

Description:

This does not support

class Foo extends Bar {
    constructor() {
        for (const i of [1]) {
            setTimeout(() => {
                console.log(this)
            });
        }
        super();
    }
}

but it does not seem to be used in a real-world code.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 19, 2024
@kdy1 kdy1 self-assigned this Feb 19, 2024
@kdy1 kdy1 requested a review from a team as a code owner February 19, 2024 06:03
Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: 6d548f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 19, 2024
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_compat_es2015

magic-akari
magic-akari previously approved these changes Feb 19, 2024
@kdy1 kdy1 dismissed stale reviews from magic-akari and kodiakhq via 6d548f5 February 19, 2024 06:24
@kdy1 kdy1 merged commit 6fe6810 into swc-project:main Feb 20, 2024
143 checks passed
@kdy1 kdy1 deleted the issue-8300 branch February 20, 2024 00:53
@kdy1 kdy1 modified the milestones: Planned, v1.4.3 Mar 5, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SWC output causes accessing this before super()
2 participants