Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(es/minifier): Update examples code #8652

Merged
merged 1 commit into from Feb 21, 2024
Merged

doc(es/minifier): Update examples code #8652

merged 1 commit into from Feb 21, 2024

Conversation

magic-akari
Copy link
Member

Related issue:

The core logic of SWC is correct, but there are incorrect code examples in our code repository.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2024 •
edited

⚠️ No Changeset found

Latest commit: 2a9c962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari
Copy link
Member Author

Is it necessary to have a standalone paren_remover pass?
Can it be integrated into the optimize pass instead?

CC @Austaras

@Austaras
Copy link
Member

Is it necessary to have a standalone paren_remover pass?

Yes since compat requires paren_remover too.

@magic-akari magic-akari marked this pull request as ready for review February 20, 2024 15:21
@magic-akari magic-akari requested a review from a team as a code owner February 20, 2024 15:21
@kdy1 kdy1 enabled auto-merge (squash) February 21, 2024 02:10
@kdy1 kdy1 changed the title fix(es/minifier): update examples code doc(es/minifier): Update examples code Feb 21, 2024
@kdy1 kdy1 added this to the Planned milestone Feb 21, 2024
kdy1
kdy1 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 merged commit 3bf3a62 into swc-project:main Feb 21, 2024
142 of 143 checks passed
@magic-akari magic-akari deleted the fix/issue-8651 branch March 4, 2024 11:35
@kdy1 kdy1 modified the milestones: Planned, v1.4.3 Mar 5, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Austaras Austaras Austaras approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

swc_ecma_minifier bad case
3 participants
@magic-akari @Austaras @kdy1