Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/module): Allow FileName::Anon from node resolver #8686

Merged
merged 15 commits into from Mar 4, 2024
Merged

fix(es/module): Allow FileName::Anon from node resolver #8686

merged 15 commits into from Mar 4, 2024
+118 −23

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 4, 2024 •
edited

@kdy1 kdy1 added this to the Planned milestone Mar 4, 2024
@kdy1 kdy1 self-assigned this Mar 4, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2024 •
edited

⚠️ No Changeset found

Latest commit: aad3f22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 mentioned this pull request Mar 4, 2024
Closed
@kdy1 kdy1 changed the title test(es/modules): Can't repro #8674 fix(es/modules): Allow FileName::Anon from node modules resolver Mar 4, 2024
kdy1
kdy1 commented Mar 4, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_loader

@kdy1 kdy1 changed the title fix(es/modules): Allow FileName::Anon from node modules resolver fix(es/module): Allow FileName::Anon from node modules resolver Mar 4, 2024
@kdy1 kdy1 marked this pull request as ready for review March 4, 2024 08:09
@kdy1 kdy1 requested review from a team as code owners March 4, 2024 08:09
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 4, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) March 4, 2024 08:09
@kdy1 kdy1 disabled auto-merge March 4, 2024 08:09
@kdy1 kdy1 changed the title fix(es/module): Allow FileName::Anon from node modules resolver fix(es/module): Allow FileName::Anon from node resolver Mar 4, 2024
@kdy1 kdy1 enabled auto-merge (squash) March 4, 2024 08:09
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 4, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 4, 2024
View reviewed changes
swc-bot
swc-bot reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 761365e into swc-project:main Mar 4, 2024
143 checks passed
@kdy1 kdy1 deleted the issue-8674 branch March 4, 2024 09:36
@kdy1 kdy1 modified the milestones: Planned, v1.4.3 Mar 5, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

jsc.baseUrl is not resolving the require/import path
2 participants
@kdy1 @swc-bot