Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend training requests and API #1293

Merged
merged 8 commits into from Jul 12, 2018
Merged

Extend training requests and API #1293

merged 8 commits into from Jul 12, 2018

Conversation

pbanaszkiewicz
Copy link
Contributor

In this rather complicated PR a number of issues were fixed:

  1. fixed Download selected trainee applications #1227 by extending API to filter by IDs and extending UI to allow for downloading various entries from training requests list
  2. fixed Trainees with training event should be automatically accepted #1284 by auto-accepting entries in training requests list when they're matched
  3. fixed Include Matched Event when downloading Training Applications #1291 by extending training requests API columns
  4. fixed Fix explanatory text for Training Application Group Name #1292 (straightforward)

@pbanaszkiewicz
Training requests: add "download filtered as CSV"
8313e50 
This partially resolves carpentries#1227 by adding the button to download filtered
requests.
@pbanaszkiewicz
API: select IDs of specific training requests
93bd835 
Add "Download selected" button with dynamically generated URL.
@pbanaszkiewicz
Accept request before matching person to a training event
e5ecd2e
@pbanaszkiewicz
Fix tests for accepting and matching training requests
0da667e
@pbanaszkiewicz
API: add tests for filtering selective IDs in training requests
6e14131
@pbanaszkiewicz
Add various columns to the training-requests API endpoint
1ae98e3 
New columns:
1) person_id
2) awards - a comma-joined list of pairs "badge award_date"
3) training_tasks - a comma-joined list of training tasks (TTT event
   names)
@pbanaszkiewicz
API: extend tests to cover new columns in training requests view
5848535
@pbanaszkiewicz
Fix hint text in TrainingRequest.group_name field
e337602
@pbanaszkiewicz pbanaszkiewicz added this to the v2.0 milestone Jul 12, 2018
@pbanaszkiewicz pbanaszkiewicz self-assigned this Jul 12, 2018
@pbanaszkiewicz pbanaszkiewicz merged commit 04562b4 into carpentries:develop Jul 12, 2018
@pbanaszkiewicz pbanaszkiewicz deleted the extend-training-requests-api branch July 24, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
component: API component: database (DB) component: user interface (UI) type: enhancement
Projects
None yet
Milestone
v2.0
1 participant
@pbanaszkiewicz