New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major lesson update #13
Merged
fmichonneau
merged 22 commits into
carpentries-incubator:gh-pages
from
resbazSQL:gh-pages
Oct 31, 2019
Merged
Major lesson update #13
fmichonneau
merged 22 commits into
carpentries-incubator:gh-pages
from
resbazSQL:gh-pages
Oct 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Greg
Have this massive pull request. (I'd be delighted to have a zoom hangout and deconstruct what parts of it you'd like to use).
Things I've done
One thing of feedback I got was that they were expecting excel. So I'd love to work with you to figure out how to incorporate openpyxl into the lesson. I've also tested all code and lifted it to python3.
Let me know what you think. I look forward to chatting with you in some detail about the decisions I made.
Cheers,
-Brian