Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major lesson update #13

Merged
merged 22 commits into from Oct 31, 2019
Merged

Conversation

Denubis
Copy link
Collaborator

@Denubis Denubis commented Jul 6, 2018

Hi Greg

Have this massive pull request. (I'd be delighted to have a zoom hangout and deconstruct what parts of it you'd like to use).

Things I've done

  1. Lifted all lessons to modern lesson example template
  2. Added 2 chapters before your bibliography content for an early bulk-loading csv win, showing how they can join data with external datasets. I built this as part of a sql->scraping->capstone workshop and I think the "you can answer a real research question" really resonated.

One thing of feedback I got was that they were expecting excel. So I'd love to work with you to figure out how to incorporate openpyxl into the lesson. I've also tested all code and lifted it to python3.

Let me know what you think. I look forward to chatting with you in some detail about the decisions I made.

Cheers,
-Brian

@Denubis
Copy link
Collaborator Author

Denubis commented Aug 2, 2018

Ping @weaverbel

@fmichonneau fmichonneau merged commit 34e8619 into carpentries-incubator:gh-pages Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants