Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-numpy: inconsistent text/images for array indexing and method calls #823

Closed
jdkent opened this issue May 26, 2020 · 2 comments · Fixed by #827
Closed

02-numpy: inconsistent text/images for array indexing and method calls #823

jdkent opened this issue May 26, 2020 · 2 comments · Fixed by #827

Comments

@jdkent
Copy link
Contributor

jdkent commented May 26, 2020

Array Indexing

The current text indexes arrays like: data[0, 0], but the image indexes the array like data[0][0].
These methods are equivalent (AFAIK), but I could not find this stated in the text.

Method Calls

The current text calls functions from numpy to operate on data (numpy.max(data, axis=1)),
but the image calls the .max() method from data (data.max(axis=1)), and I did not find explicit mention of their equivalency in the text.

Thanks for all your work on these lessons, let me know if I'm missing something that makes this a non-issue.

@ldko
Copy link
Contributor

ldko commented May 26, 2020

Hi @jdkent, thanks for pointing out the inconsistencies. I think in both cases, it would be desirable to update the images to match the text. Regarding the data.max vs. numpy.max function or method issue, previously the method was also used in the text, but a decision was made to consistently use functions over the methods. The image has not been updated to match since then. In the array indexing, I am not sure about why the image uses the data[0][0] syntax instead of data[0, 0], which is the syntax given in the episode text and numpy documentation, so it would be good to change to prevent confusion. Would you be able to submit a pull request to update the images to remedy the inconsistencies? Thank you!

@ldko
Copy link
Contributor

ldko commented Aug 17, 2020

Hi James, just want to check and see if you think you will have time to work on this in the near future. Thank you!

@ldko ldko closed this as completed in #827 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants