Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time setting must be "flingable" #14

Closed
Marmotian opened this issue Oct 24, 2022 · 3 comments
Closed

Time setting must be "flingable" #14

Marmotian opened this issue Oct 24, 2022 · 3 comments

Comments

@Marmotian
Copy link

Marmotian commented Oct 24, 2022

Setting the alarm is very motion intensive because you can't use a "fling" gesture to cause the setting to change quickly. The worst case (changing the minutes by 30) takes a minimum of 8 full-screen swipes on my phone.

Or, make it so you can tap the numbers to open a keyboard entry mode. Or both.

@domportera
Copy link
Contributor

I tried forking and messing with this and found some difficulties in getting the "fling" to work properly or respond to different parameters in a predictable and intuitive way.

However in the meantime I just sped up the Minutes control. it's a little bit unwieldy, but imo it's preferred for the time being. I made a thoroughly under-tested build you can grab here if you're itching for it, but I can't say I recommend it. I'll be using it though.

I'm wondering what @sweakpl thinks of this sort of architecture for these sorts of changes. It's basically my first time in kotlin/android studio so forgive me for being somewhat crude

@sweakpl
Copy link
Owner

sweakpl commented Dec 13, 2022

@domportera I've tried implementing the fling but it's been a harder task than I though it should be. The code responsible for the time picker is a modification of this gist: https://gist.github.com/vganin/a9a84653a9f48a2d669910fbd48e32d5

There are some suggestions from the author there but still, I couldn't find a way to get that functionality or I've just spent too little time on it.

@domportera
Copy link
Contributor

domportera commented Dec 22, 2022

I haven't gotten into depth of that code, but I submitted a pull request for an optional speed increase. Its presentation when the speed is increased is a bit janky, but it works. fixed that lol

@sweakpl sweakpl closed this as completed in 624b6ce Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants