Usability improvements #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for your work! I will look into it as soon as I have my other things sorted out 😅 |
|
no worries, take your time! thank you for your work on making the app in the first place :)
|
includes a separate time state for optimization / flexibility, also cleaned up some semicolons and inlines
|
Hey, I've decided to build upon your commit with the support for barcodes. Thanks for contribution! :D When it comes to the no-code alarm dismissal before alarm goes off, I've decided not to implement that functionality (more here) The rest of the ideas might possibly be added in the future, but for now I'm closing this PR. |
|
no problem! glad i can be of some help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit:
4. Display time until alarm time shown