Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 17 #255

Closed
jandeu opened this issue Nov 20, 2023 · 7 comments
Closed

Support for Angular 17 #255

jandeu opened this issue Nov 20, 2023 · 7 comments

Comments

@jandeu
Copy link

jandeu commented Nov 20, 2023

Please update dependencies to support Angular 17

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^14.0.0 || ^15.0.0 || ^16.0.0" from @sweetalert2/ngx-sweetalert2@12.2.0
npm ERR! node_modules/@sweetalert2/ngx-sweetalert2
npm ERR!   @sweetalert2/ngx-sweetalert2@"^12.2.0" from the root project
@jandeu
Copy link
Author

jandeu commented Nov 20, 2023

There is already opened PR #252

@ivanvastag
Copy link

Will this get merged any time soon?

@FGO-LPCR
Copy link

Any news on this issue? @limonte @toverux @zenflow

@D-Biela
Copy link

D-Biela commented Dec 19, 2023

Any news?

@DanielInova
Copy link

My company will stop using sweetalert because of the horrible repo-/ code-management. Every major angular-version we had to wait for weeks for an update, which mostly involved changing one digit to match the current angular-version...

@Lucasrsv1
Copy link

Until the PR is merged, we can workaround this error by adding the following override to package.json:

"overrides": {
	"@sweetalert2/ngx-sweetalert2": {
		"@angular/common": "^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0",
		"@angular/core": "^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0"
	}
}

I hope this helps.

@limonte
Copy link
Member

limonte commented Feb 16, 2024

🎉 This issue is solved in version 12.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@limonte limonte closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants