Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borderless theme #15

Closed
limonte opened this issue May 2, 2019 · 9 comments
Closed

Borderless theme #15

limonte opened this issue May 2, 2019 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@limonte
Copy link
Member

limonte commented May 2, 2019

The inspiration can be taken from the Supervan theme from here: https://craftpip.github.io/angular-confirm/

The name of the theme is to be discussed. For now, it's borderless butI'm opened for better naming suggestions.

image

@limonte limonte added good first issue Good for newcomers help wanted Extra attention is needed labels May 2, 2019
@limonte
Copy link
Member Author

limonte commented May 2, 2019

If anybody is willing to help, here's the quick start guide: https://github.com/sweetalert2/sweetalert2-themes#contributing

To avoid people working on the same task, please leave a comment here before starting to work.

Thank you ❤️

@Kalvisan
Copy link
Contributor

Kalvisan commented May 3, 2019

This one looks cool. I should give it a try. Maybe you got some more images/ideas about design?

@limonte
Copy link
Member Author

limonte commented May 3, 2019

Great! Please go ahead @Kalvisan

As I understand correctly:

  • the popup background ($swal2-background) should be set to transparent
  • the backdrop background color $swal2-backdrop should be set to rgba(54, 70, 93, .99)
  • the popup text color should be changed to white
  • etc.

@Kalvisan
Copy link
Contributor

Added pull request: #19

@Kalvisan
Copy link
Contributor

You closed the wrong one!

And what about Toast style. You changed in commit 5820967 my workaround to fix same font color as background color. Same for select style.

@limonte
Copy link
Member Author

limonte commented May 10, 2019

You closed the wrong one!

Oops, reopened that one :)

And what about Toast style. You changed in commit 5820967 my workaround to fix same font color as background color.

I don't see much value in borderless toasts, let's ignore theme in borderless theme.

Same for select style.

Oops, that's a mistake, I'll fix that 👍

PS: https://sweetalert2.github.io/ - the borderless theme is available:

image

@Kalvisan
Copy link
Contributor

Borderless theme broke Toast modal.

@limonte
Copy link
Member Author

limonte commented May 10, 2019

Borderless theme broke Toast modal.

Fixed now:

image

@limonte
Copy link
Member Author

limonte commented May 10, 2019

Great work, thank you so much for your cooperation @Kalvisan

@limonte limonte closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants