Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 Theme CSS Values alignment #73

Open
GeoSot opened this issue Jun 25, 2021 · 1 comment
Open

Bootstrap 4 Theme CSS Values alignment #73

GeoSot opened this issue Jun 25, 2021 · 1 comment

Comments

@GeoSot
Copy link

GeoSot commented Jun 25, 2021

New feature motivation

Trying ti adopt the bootstrap theme into my app, I realized that scss is initialized using the default bootstrap values and not these given from bootstrap's variables file. So It can't follow any bootstrap customization

New feature description

It could be possible to align variables with bootstrap scss variables (select2 themes applies this method). just to include the following before build

@import "~bootstrap/scss/functions";
@import "~bootstrap/scss/variables";
@import "~bootstrap/scss/mixins";

and change the fixed values of the following lines to the proper variables

$bootstrap-primary: #007bff !default;
$bootstrap-success: #28a745 !default;
$bootstrap-danger: #dc3545 !default;
$bootstrap-warning: #ffc107 !default;
$bootstrap-info: #17a2b8 !default;
$bootstrap-secondary: #6c757d !default;
$bootstrap-gray-100: #f8f9fa !default;
$bootstrap-gray-200: #e9ecef !default;
$bootstrap-gray-300: #dee2e6 !default;
$bootstrap-gray-400: #ced4da !default;
$bootstrap-gray-500: #adb5bd !default;
$bootstrap-gray-600: #6c757d !default;
$bootstrap-gray-700: #495057 !default;
$bootstrap-gray-800: #343a40 !default;
$bootstrap-gray-900: #212529 !default;
$bootstrap-theme-color-interval: 8% !default;
// Alert
$bootstrap-alert-border-level: -9 !default;
$bootstrap-alert-bg-level: -10 !default;
$bootstrap-alert-color-level: 6 !default;
$bootstrap-alert-border-color: mix($swal2-white, $bootstrap-secondary, abs($bootstrap-alert-border-level) * $bootstrap-theme-color-interval) !default;
$bootstrap-alert-background: mix($swal2-white, $bootstrap-secondary, abs($bootstrap-alert-bg-level) * $bootstrap-theme-color-interval) !default;
$bootstrap-alert-color: mix($swal2-black, $bootstrap-secondary, abs($bootstrap-alert-color-level) * $bootstrap-theme-color-interval) !default;
$bootstrap-alert-padding-y: .75rem !default;
$bootstrap-alert-padding-x: 1.25rem !default;
$bootstrap-alert-margin-bottom: 1rem !default;
$bootstrap-alert-border-radius: .25rem !default;
$bootstrap-alert-border-width: 1px !default;
$bootstrap-alert-font-size: 1rem !default;
// Input
$bootstrap-input-color: $bootstrap-gray-700 !default;
$bootstrap-input-bg: $swal2-white !default;
$bootstrap-input-border-color: $bootstrap-gray-300 !default;
$bootstrap-input-border-radius: .25rem !default;
$bootstrap-input-border-width: 1px !default;
$bootstrap-input-padding-y: .375rem !default;
$bootstrap-input-padding-x: .75rem !default;
$bootstrap-input-line-height: 1.5 !default;
$bootstrap-input-height-border: $bootstrap-input-border-width * 2 !default;
$bootstrap-input-height: calc(#{$bootstrap-input-line-height * 1em} + #{$bootstrap-input-padding-y * 2} + #{$bootstrap-input-height-border}) !default;
$bootstrap-input-disabled-color: $swal2-white !default;
$bootstrap-input-disabled-bg: $bootstrap-gray-200 !default;
$bootstrap-input-focus-width: .2rem !default;
$bootstrap-input-focus-border: 1px solid lighten($bootstrap-primary, 25%) !default;
$bootstrap-input-focus-box-shadow: 0 0 0 $bootstrap-input-focus-width rgba($bootstrap-primary, .25) !default;
// Button
$bootstrap-btn-transition: color .15s ease-in-out, background-color .15s ease-in-out, border-color .15s ease-in-out, box-shadow .15s ease-in-out !default;
$bootstrap-btn-secondary-focus-box-shadow: 0 0 0 $bootstrap-input-focus-width rgba($bootstrap-secondary, .25) !default;
// Custom Shared Variables
$bootstrap-custom-forms-transition: background-color .15s ease-in-out, border-color .15s ease-in-out, box-shadow .15s ease-in-out !default;
$bootstrap-custom-control-gutter: .5rem !default;
$bootstrap-custom-control-indicator-size: 1rem !default;
$bootstrap-custom-control-indicator-bg: $swal2-white !default;
$bootstrap-custom-control-indicator-bg-size: 50% 50% !default;
$bootstrap-custom-control-indicator-border-color: $bootstrap-gray-500 !default;
$bootstrap-custom-control-indicator-border-width: $bootstrap-input-border-width !default;
$bootstrap-custom-control-indicator-checked-color: $swal2-white !default;
$bootstrap-custom-control-indicator-checked-bg: $bootstrap-primary !default;
$bootstrap-custom-control-indicator-checked-disabled-bg: rgba($bootstrap-primary, .5) !default;
$bootstrap-custom-control-indicator-checked-border-color: $bootstrap-custom-control-indicator-checked-bg !default;
$bootstrap-custom-control-indicator-active-color: $swal2-white !default;
$bootstrap-custom-control-indicator-active-bg: lighten($bootstrap-primary, 35%) !default;
$bootstrap-custom-control-indicator-active-box-shadow: none !default;
$bootstrap-custom-control-indicator-active-border-color: $bootstrap-custom-control-indicator-active-bg !default;
$bootstrap-custom-control-indicator-focus-box-shadow: $bootstrap-input-focus-box-shadow !default;
$bootstrap-custom-control-indicator-focus-border-color: lighten($bootstrap-primary, 25%) !default;
// Custom Select
$bootstrap-custom-select-bg-size: 8px 10px !default;
$bootstrap-custom-select-indicator-color: $bootstrap-gray-800 !default;
$bootstrap-custom-select-indicator: str-replace(url('data:image/svg+xml,%3csvg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 4 5"%3e%3cpath fill="#{$bootstrap-custom-select-indicator-color}" d="M2 0L0 2h4zm0 5L0 3h4z"/%3e%3c/svg%3e'), '#', '%23') !default;
$bootstrap-custom-select-background: $bootstrap-custom-select-indicator no-repeat right $bootstrap-input-padding-x center / $bootstrap-custom-select-bg-size !default; // Used so we can have multiple background elements (e.g., arrow and feedback icon)
// Custom Radio
$bootstrap-custom-radio-indicator-border-radius: 50% !default;
$bootstrap-custom-radio-indicator-icon-checked: str-replace(url('data:image/svg+xml,%3csvg xmlns="http://www.w3.org/2000/svg" viewBox="-4 -4 8 8"%3e%3ccircle r="3" fill="#{$bootstrap-custom-control-indicator-checked-color}"/%3e%3c/svg%3e'), '#', '%23') !default;
// Custom Checkbox
$bootstrap-custom-checkbox-indicator-icon-checked: str-replace(url('data:image/svg+xml,%3csvg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 8 8"%3e%3cpath fill="#{$bootstrap-custom-control-indicator-checked-color}" d="M6.564.75l-3.59 3.612-1.538-1.55L0 4.26 2.974 7.25 8 2.193z"/%3e%3c/svg%3e'), '#', '%23') !default;
// Custom Range
$bootstrap-custom-range-track-width: 100% !default;
$bootstrap-custom-range-track-height: .5rem !default;
$bootstrap-custom-range-track-cursor: pointer !default;
$bootstrap-custom-range-track-bg: $bootstrap-gray-300 !default;
$bootstrap-custom-range-track-border-radius: 1rem !default;
$bootstrap-custom-range-track-box-shadow: inset 0 .25rem .25rem rgba($swal2-black, .1) !default;
$bootstrap-custom-range-thumb-width: 1rem !default;
$bootstrap-custom-range-thumb-height: $bootstrap-custom-range-thumb-width !default;
$bootstrap-custom-range-thumb-bg: $bootstrap-primary !default;
$bootstrap-custom-range-thumb-border: 0 !default;
$bootstrap-custom-range-thumb-border-radius: 1rem !default;
$bootstrap-custom-range-thumb-box-shadow: 0 .1rem .25rem rgba($swal2-black, .1) !default;
$bootstrap-custom-range-thumb-focus-box-shadow: 0 0 0 1px $swal2-white, $bootstrap-input-focus-box-shadow !default;
$bootstrap-custom-range-thumb-focus-box-shadow-width: $bootstrap-input-focus-width !default; // For focus box shadow issue in IE/Edge
$bootstrap-custom-range-thumb-active-bg: lighten($bootstrap-primary, 35%) !default;
$bootstrap-custom-range-thumb-disabled-bg: $bootstrap-gray-500 !default;
// Toast
$bootstrap-toast-max-width: 350px !default;
$bootstrap-toast-padding-x: .75rem !default;
$bootstrap-toast-padding-y: .25rem !default;
$bootstrap-toast-font-size: .875rem !default;
$bootstrap-toast-background-color: rgba($swal2-white, .85) !default;
$bootstrap-toast-border-width: 1px !default;
$bootstrap-toast-border-color: rgba(0, 0, 0, .1) !default;
$bootstrap-toast-border-radius: .25rem !default;
$bootstrap-toast-box-shadow: 0 .25rem .75rem rgba($swal2-black, .1) !default;


PS: If you like , could help on this

@limonte
Copy link
Member

limonte commented Jun 26, 2021

I would really appreciate your help @GeoSot, thanks for reporting! Let me know if you have any questions about contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants