Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Flashing When Transitioning Between Modals #1899

Closed
Souleste opened this issue Feb 21, 2020 · 3 comments · Fixed by #1900
Closed

Prevent Flashing When Transitioning Between Modals #1899

Souleste opened this issue Feb 21, 2020 · 3 comments · Fixed by #1900
Labels
released

Comments

@Souleste
Copy link

Currently when transitioning between modals the backdrop flashes, which I would understand to happen when "firing" a new sweet alert, but I think it should at least not do this when queuing modals.
@gverni
Copy link
Contributor

gverni commented Feb 22, 2020

We can probably use the data-swal2-queue-step or the data-queue-step attributes to detect we are rendering a queue and prevent the removal of the backdrop. I'll check we are not messing up with other corner cases and get back to you..

@limonte limonte mentioned this issue Feb 22, 2020
Merged
@limonte
Copy link
Member

limonte commented Feb 22, 2020

Thank you for reporting @Souleste!

This was bothering me as well, but since nobody reported the issue it was never addressed :)

@limonte
Copy link
Member

limonte commented Feb 22, 2020

🎉 This issue has been resolved in version 9.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not animate backdrop for queues sweetalert2/sweetalert2
3 participants
@limonte @gverni @Souleste