Use DOMParser to secure setting innerHTML #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good, all tests are passing. I'll go ahead and merge it, but the release will be done tomorrow. If anybody has anything to add here, please do so. Once again, thank you @september28 for the exemplary issue-report 馃憦 |
|
Some tests are failing in IE11: https://github.com/sweetalert2/sweetalert2/runs/541098252?check_suite_focus=true |
limonte
added a commit
that referenced
this pull request
Mar 28, 2020
limonte
added a commit
that referenced
this pull request
Mar 28, 2020
limonte
added a commit
that referenced
this pull request
Mar 28, 2020
limonte
added a commit
that referenced
this pull request
Mar 28, 2020
limonte
pushed a commit
that referenced
this pull request
Mar 28, 2020
## [9.10.7](v9.10.6...v9.10.7) (2020-03-28) ### Bug Fixes * use DOMParset only if html is not empty ([#1931](#1931)) ([54463ec](54463ec)), closes [/github.com//pull/1930#issuecomment-605412269](https://github.com//github.com/sweetalert2/sweetalert2/pull/1930/issues/issuecomment-605412269) * use DOMParset to secure setting innerHTML ([#1930](#1930)) ([18c5a63](18c5a63))
|
馃帀 This PR is included in version 9.10.7 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
## [9.10.7](sweetalert2/sweetalert2@v9.10.6...v9.10.7) (2020-03-28) ### Bug Fixes * use DOMParset only if html is not empty ([sweetalert2#1931](sweetalert2#1931)) ([56f0928](sweetalert2@56f0928)), closes [/github.com/sweetalert2/pull/1930#issuecomment-605412269](https://github.com//github.com/sweetalert2/sweetalert2/pull/1930/issues/issuecomment-605412269) * use DOMParset to secure setting innerHTML ([sweetalert2#1930](sweetalert2#1930)) ([dedec23](sweetalert2@dedec23))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1926
element.innerHTML= is not used anymore 馃帀 Instead,DOMParseris used, docs: https://developer.mozilla.org/en-US/docs/Web/API/DOMParserMany thanks to @september28 for his valuable input!