Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsetting aria-hidden="true" when modal is called twice #2306

Merged
merged 2 commits into from Aug 3, 2021

Conversation

limonte
Copy link
Member

@limonte limonte commented Aug 3, 2021

Fixes #2303

@limonte limonte force-pushed the fix/aria-hidden-when-swal-called-twice branch from 8c522e6 to 21a5776 Compare August 3, 2021 10:26
@limonte limonte marked this pull request as ready for review August 3, 2021 10:33
@limonte limonte merged commit 64223a7 into master Aug 3, 2021
@limonte limonte deleted the fix/aria-hidden-when-swal-called-twice branch August 3, 2021 10:33
github-actions bot pushed a commit that referenced this pull request Aug 3, 2021
## [11.1.1](v11.1.0...v11.1.1) (2021-08-03)

### Bug Fixes

* unsetting `aria-hidden="true"` when modal is called twice ([#2306](#2306)) ([64223a7](64223a7))
@limonte
Copy link
Member Author

limonte commented Aug 3, 2021

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this pull request Mar 29, 2023
matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this pull request Mar 29, 2023
## [11.1.1](sweetalert2/sweetalert2@v11.1.0...v11.1.1) (2021-08-03)

### Bug Fixes

* unsetting `aria-hidden="true"` when modal is called twice ([sweetalert2#2306](sweetalert2#2306)) ([7f4d790](sweetalert2@7f4d790))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aria-hidden getting set and not unset
1 participant