Skip to content
This repository has been archived by the owner on Feb 14, 2020. It is now read-only.

Add consistent serialization #7

Open
wcurtis opened this issue Sep 17, 2015 · 0 comments
Open

Add consistent serialization #7

wcurtis opened this issue Sep 17, 2015 · 0 comments
Labels

Comments

@wcurtis
Copy link
Member

wcurtis commented Sep 17, 2015

Right now serializing the payload of the webhook is super basic, just calling getData() on the model. This is all kinds of bad because it will expose sensitive information like password hashes and such. A better strategy would be to create a serializer for each resource. An even better strategy is if we could re-use the serializer for the REST API so our webhook data has an identical json structure to the API. Boom.

All feedback or recommendations welcome

@wcurtis wcurtis added the RFC label Sep 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant