Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port liblrdf to raptor2 #1

Closed
ssuominengentoo opened this issue Aug 7, 2011 · 11 comments
Closed

Port liblrdf to raptor2 #1

ssuominengentoo opened this issue Aug 7, 2011 · 11 comments
Assignees

Comments

@ssuominengentoo
Copy link

Both ArchLinux and Gentoo come with raptor2 patched liblrdf, but ArchLinux is missing pkgconfig patch required by reverse dependencies to get -I include flags to find raptor.h as well as -lraptor2 for static linking.

Please see both -raptor2 and -raptor2-pkgconfig patches from here:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/liblrdf/files/

@taybin
Copy link
Collaborator

taybin commented Aug 15, 2011

That's great! I'll take a look at it and try to merge it in. Care to make a pull request?

@ghost ghost assigned taybin Aug 15, 2011
@ssuominengentoo
Copy link
Author

And to provide migration plan for distribution maintainers, in addition to patching liblrdf, these needed fixing too:

http://qa-reports.gentoo.org/output/genrdeps/rindex/media-libs/liblrdf

Aqualung:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-sound/aqualung/files/aqualung-0.9_beta11-use_lrdf_cflags.patch?revision=1.1&view=markup

Ardour:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-sound/ardour/files/ardour-2.8.11-raptor2.patch?revision=1.1&view=markup

Galan:

This package is "dead" at upstream so I was lazy and simply appended pkg-confg --cflags lrdf to CPPFLAGS instead of writing a proper patch for it.

Hydrogen:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-sound/hydrogen/files/hydrogen-0.9.5-use_lrdf_pkgconfig.patch?revision=1.1&view=markup

(But something is wrong with the build system, as the flags get lost during half of the build. As in, the patch is a bit incomplete. I used this patch and the same workaround as Galan above.)

Jack-Rack:

Same as Galan, simply passed pkg-config --clags lrdf to CPPFLAGS.

Rosegarden:

Worked out of box after applying the 2 patches to lrdf.

Sonic Visualiser:

Applied workaround from here http://code.soundsoftware.ac.uk/issues/136
It doesn't need to check for presense of raptor, because it simply gains it from liblrdf
after the 2 patches are applied.

TerminatorX:

Seems to just work...

Overall, liblrdf reverse dependency upstream maintainers need to use more pkg-config, and assume locations less.

@taybin
Copy link
Collaborator

taybin commented Aug 16, 2011

Used the basic raptor2 patch and build system modifications.

I also removed the private MD5 implementation and replaced it with MD5() from openssl.

I'm going to wait a little bit for comments, and then tag 0.5.0.

@amitkulz
Copy link
Contributor

taybin, will you please tag 0.5.0? we can use an update.

ssuominengentoo, thanks a bunch for hunting it down. don't you need liblrdf for gstreamer-plugins-bad too?

thanks a bunch for working on this guys!

@ssuominengentoo
Copy link
Author

amitkulz, most likely but it seems Gentoo Linux Gstreamer maintainers haven't packaged this plug-in from the -bad bundle, so I've missed it.

taybin, yes please tag 0.5.0 after committing fix for http://github.com/swh/LRDF/issues/3

@taybin
Copy link
Collaborator

taybin commented Sep 19, 2011

Fixed issue #3. I'm just cleaning up an issue with make distcheck and then I hope to tag.

@ssuominengentoo
Copy link
Author

I made a git snapshot and shipped it in Gentoo's Portage but I stumbled over:

#5
#6

When packaging it.

In any case, it should now get a bit more wider testing...

@amitkulz
Copy link
Contributor

good thing you found those issues before the tag :-)

@taybin
Copy link
Collaborator

taybin commented Oct 4, 2011

Fixed those two issues. Please retest and then I will finally tag.

@ssuominengentoo
Copy link
Author

The current git worked for me out of box now. Thanks

@ssuominengentoo
Copy link
Author

Time to close this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants