Remove setq-local usages

[chrisbarrett]

Replace with (set (make-local-variable ...) ...). This is compatible with older emacsen and will allow removal of the reimplementation of setq-local.

[bbatsov]

Bad idea, mate. Simply inline it like this:

;;; Compatibility
(eval-and-compile
  ;; `setq-local' for Emacs 24.2 and below
  (unless (fboundp 'setq-local)
    (defmacro setq-local (var val)
      "Set variable VAR to value VAL in current buffer."
      `(set (make-local-variable ',var) ,val))))

No need to degrade the code, when the solution is so simple. Btw, you'd be crazy to supporting anything older than Emacs 24.1.

[bbatsov]

I see you've already done that, so I don't see the point in this issue.

[chrisbarrett]

This came up in feedback on my MELPA pull request. See @purcell's comments at melpa/melpa#1748

I'm not fussed either way, I just want this package to be a good citizen.

[purcell]

@bbatsov It's still bad practice to shim built-in functions/macros, generally speaking, for the reasons I described in the comments on melpa/melpa#1748. This isn't the most egregious example, though. :-)