We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should not depend on the NIO umbrella module.
Instead we should explicitly
import NIOCore
import NIOPosix
import NIOConcurrencyHelpers
import NIOEmbedded
where needed.
We should also add explicit dependencies in the Package.swift
Package.swift
This code in scripts/soundness.sh can be commented in again and CI passes:
scripts/soundness.sh
# This checks for the umbrella NIO module. printf "=> Checking for imports of umbrella NIO module... " if git grep --color=never -i "^[ \t]*import \+NIO[ \t]*$" > /dev/null; then printf "\033[0;31mUmbrella imports found.\033[0m\n" git grep -i "^[ \t]*import \+NIO[ \t]*$" exit 1 fi printf "\033[0;32mokay.\033[0m\n"
The text was updated successfully, but these errors were encountered:
Joannis
Successfully merging a pull request may close this issue.
We should not depend on the NIO umbrella module.
Instead we should explicitly
import NIOCore
import NIOPosix
import NIOConcurrencyHelpers
import NIOEmbedded
where needed.
We should also add explicit dependencies in the
Package.swift
Acceptance criteria:
This code in
scripts/soundness.sh
can be commented in again and CI passes:The text was updated successfully, but these errors were encountered: