Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all NIO umbrella imports #59

Closed
fabianfett opened this issue Jun 16, 2023 · 0 comments · Fixed by #60
Closed

Remove all NIO umbrella imports #59

fabianfett opened this issue Jun 16, 2023 · 0 comments · Fixed by #60
Assignees

Comments

@fabianfett
Copy link
Member

We should not depend on the NIO umbrella module.

Instead we should explicitly

  • import NIOCore
  • import NIOPosix
  • import NIOConcurrencyHelpers
  • import NIOEmbedded
  • ...

where needed.

We should also add explicit dependencies in the Package.swift

Acceptance criteria:

This code in scripts/soundness.sh can be commented in again and CI passes:

# This checks for the umbrella NIO module.
printf "=> Checking for imports of umbrella NIO module... "
if git grep --color=never -i "^[ \t]*import \+NIO[ \t]*$" > /dev/null; then
    printf "\033[0;31mUmbrella imports found.\033[0m\n"
    git grep -i "^[ \t]*import \+NIO[ \t]*$"
    exit 1
fi
printf "\033[0;32mokay.\033[0m\n"
@Joannis Joannis self-assigned this Jun 16, 2023
@Joannis Joannis linked a pull request Jun 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants